Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-component): localization support #3604

Merged
merged 42 commits into from
Sep 5, 2023
Merged

Conversation

pramodcog
Copy link
Contributor

@pramodcog pramodcog commented Aug 21, 2023

Type of change

Feat

Jira ticket 📘

https://cognitedata.atlassian.net/browse/UX-1220

Description 📝

Localization of react-components

How has this been tested? 🔍

In storybook & FDX though yalc symbolic link

Test instructions ℹ️

  • cd react-components && yarn && yarn build && yarn storybook
  • Select Toolbar example and click on Help button.

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@pramodcog pramodcog added auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack labels Aug 21, 2023
@pramodcog pramodcog removed the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Aug 22, 2023
@pramodcog pramodcog added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Sep 4, 2023
@pramodcog pramodcog marked this pull request as ready for review September 4, 2023 11:00
@pramodcog pramodcog requested a review from a team as a code owner September 4, 2023 11:00
Copy link
Contributor

@christjt christjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, other than that it looks great :)

.github/workflows/locize-sync.yml Outdated Show resolved Hide resolved
react-components/src/common/i18n/index.tsx Outdated Show resolved Hide resolved
react-components/src/common/i18n/index.tsx Outdated Show resolved Hide resolved
react-components/package.json Show resolved Hide resolved
react-components/yarn.lock Show resolved Hide resolved
@pramodcog pramodcog merged commit 4c59d22 into master Sep 5, 2023
26 checks passed
@pramodcog pramodcog deleted the pramodcog/UX-1220 branch September 5, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants