Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: shared 3D-to-FDM node cache #3588

Merged
merged 20 commits into from
Aug 16, 2023
Merged

Conversation

haakonflatval-cognite
Copy link
Contributor

Type of change

Feat

Jira ticket 📘

https://cognitedata.atlassian.net/browse/

Description 📝

Shared cache between all-asset-mappings requests and node-to-asset-mapping requests.

Complicated by the fact that clicks on subnode are not automatically recognized as clicks on the asset mapped node itself. Also, the node-to-asset-mapping request will want more than just the edge-data, and will have to do additional requests even on cache hit on the all-asset-mappings-cache.

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite added the slack PRs and issues with this label will be pushed to Slack label Aug 16, 2023
@haakonflatval-cognite haakonflatval-cognite marked this pull request as ready for review August 16, 2023 13:45
@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner August 16, 2023 13:45
Copy link
Contributor

@christjt christjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks really, really good! Only a little feedback on some nits. Other than that it doesn't seem to fully cache in highlight node example, so you probably have to give that a go and figure out what is going wrong.

@haakonflatval-cognite haakonflatval-cognite added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Aug 16, 2023
@haakonflatval-cognite haakonflatval-cognite merged commit cff071e into master Aug 16, 2023
13 checks passed
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/node-cache branch August 16, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants