Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-components): add default resource styling prop to 3DResources #3580

Merged
merged 5 commits into from
Aug 14, 2023

Conversation

christjt
Copy link
Contributor

Type of change

Feat

Description 📝

Trying to dogfood styling was hard. Need to be able to set styles to all types of a given resource type.

@christjt christjt added auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack labels Aug 14, 2023
@christjt christjt requested a review from a team as a code owner August 14, 2023 12:46
@christjt christjt enabled auto-merge (squash) August 14, 2023 13:35
Copy link
Contributor

@pramodcog pramodcog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor observation

@christjt christjt merged commit 6b259d9 into master Aug 14, 2023
13 checks passed
@christjt christjt deleted the christjt/add-default-resource-styling branch August 14, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants