-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-components): 3D resources Submenu disappear in FDX when hovered #3570
fix(react-components): 3D resources Submenu disappear in FDX when hovered #3570
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice that you found a workaround for that cogs issue! I think we should not use dom id's though because react manipulates it a lot, so it would be safer to use refs and pass it in some way.
react-components/src/components/RevealToolbar/LayersContainer/CadModelLayersContainer.tsx
Outdated
Show resolved
Hide resolved
…ttps://github.com/cognitedata/reveal into pramodcog/fix-layers-component-submenu-hover-issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/UX-1218
Description 📝
Tippy
element used byCogs.js's
inMenu.Submenu
is having issue on hover ofMenu.item
when used as nestedMenu.Submenu
item asTippy
was appending toroot
div rather than it's parent. This PR fixes the issue appearing in FDX.Explore._.Cognite.Data.Fusion.-.Google.Chrome.2023-08-11.15-59-53.mp4
How has this been tested? 🔍
In Storybook and FDX via local symbolic link
Test instructions ℹ️
cd react-components && yarn && yarn build && yarn storybook
Select
LayersContainer
exampleChecklist ☑️