Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-components): 3D resources Submenu disappear in FDX when hovered #3570

Merged
merged 13 commits into from
Aug 14, 2023

Conversation

pramodcog
Copy link
Contributor

Type of change

Bug

Jira ticket 📘

https://cognitedata.atlassian.net/browse/UX-1218

Description 📝

Tippy element used by Cogs.js's in Menu.Submenu is having issue on hover of Menu.item when used as nested Menu.Submenu item as Tippy was appending to root div rather than it's parent. This PR fixes the issue appearing in FDX.

Explore._.Cognite.Data.Fusion.-.Google.Chrome.2023-08-11.15-59-53.mp4

How has this been tested? 🔍

In Storybook and FDX via local symbolic link

Test instructions ℹ️

cd react-components && yarn && yarn build && yarn storybook
Select LayersContainer example

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@pramodcog pramodcog added auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack labels Aug 11, 2023
@pramodcog pramodcog requested a review from a team as a code owner August 11, 2023 14:11
Copy link
Contributor

@Savokr Savokr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice that you found a workaround for that cogs issue! I think we should not use dom id's though because react manipulates it a lot, so it would be safer to use refs and pass it in some way.

@pramodcog pramodcog requested a review from Savokr August 14, 2023 12:05
Copy link
Contributor

@Savokr Savokr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pramodcog pramodcog merged commit 231f367 into master Aug 14, 2023
13 checks passed
@pramodcog pramodcog deleted the pramodcog/fix-layers-component-submenu-hover-issue branch August 14, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants