Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react-components): add support for system data models to react components #3569

Merged
merged 14 commits into from
Aug 14, 2023
Merged

feat(react-components): add support for system data models to react components #3569

merged 14 commits into from
Aug 14, 2023

Conversation

christjt
Copy link
Contributor

@christjt christjt commented Aug 11, 2023 •
edited
Loading

Type of change

Feat

Description 📝

Uses system data models instead of FDM config.

Many thing are still suboptimal but adding a PR to be able to move forward.

  • Styling is not cached, i.e. when anything changes we flush everything.
  • Highlighting seems bugged now (style flushing is very visible, and there seems to be an issue in reveal causing clicked objects to suddanly dissappear, but it comes back if you move the camera a little)
  • The fetching of the mapped nodes should be an infinite query such that partial styling can be applied as you go.
  • Missing the ability to scope mapped nodes.

Test instructions ℹ️

Model styling story and highlighting story have been updated.

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@christjt christjt added auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack labels Aug 11, 2023
@christjt christjt requested a review from a team as a code owner August 11, 2023 13:32
haakonflatval-cognite
haakonflatval-cognite requested changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor change requests - but otherwise looks fine 👍

react-components/stories/Reveal3DResources.stories.tsx Outdated Show resolved Hide resolved
react-components/stories/HighlightNode.stories.tsx Show resolved Hide resolved
react-components/src/utilities/FdmSDK.ts Show resolved Hide resolved
react-components/src/hooks/useMappedEquipmentBy3DModelsList.tsx Outdated Show resolved Hide resolved
react-components/src/hooks/useCalculateModelsStyling.tsx Outdated Show resolved Hide resolved
react-components/src/components/Reveal3DResources/queryMappedData.ts Show resolved Hide resolved
react-components/src/components/Reveal3DResources/Reveal3DResources.tsx Show resolved Hide resolved
haakonflatval-cognite
haakonflatval-cognite approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christjt christjt merged commit c07ded1 into master Aug 14, 2023
13 checks passed
@christjt christjt deleted the christjt/react-components-system-datamodel branch August 14, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haakonflatval-cognite haakonflatval-cognite haakonflatval-cognite approved these changes

Assignees
No one assigned
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christjt @haakonflatval-cognite