Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react-components): help button in toolbar #3564

Merged
merged 14 commits into from
Aug 10, 2023
Merged

feat(react-components): help button in toolbar #3564

merged 14 commits into from
Aug 10, 2023

Conversation

pramodcog
Copy link
Contributor

@pramodcog pramodcog commented Aug 8, 2023 •
edited
Loading

Type of change

Feat

Jira ticket 📘

https://cognitedata.atlassian.net/browse/UX-979

Description 📝

Help Button in toolbar for Navigation

Figma Link

Implemented preview image from storybook (Updated)
image

How has this been tested? 🔍

In Storybook

Test instructions ℹ️

cd react-components && yarn && yarn build && yarn storybook
Select Help button from Toolbar

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@pramodcog pramodcog added auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack labels Aug 8, 2023
@pramodcog pramodcog requested a review from a team as a code owner August 8, 2023 13:40
haakonflatval-cognite
haakonflatval-cognite requested changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpick, otherwise looks good 👍 I gave some oral feedback as well:

  • Text can be a bit hard to read sometimes, seems to be fixed with alpha adjustment
  • Layout is not entirely correct, run by design (Kerem) to check if it needs improvements
  • Switch Left/Right arrow key descriptions
  • Include the small tap at the left of the component (again, we could see if design is flexible with this)

react-components/src/components/Graphics/Keyboard.tsx Outdated Show resolved Hide resolved
react-components/src/components/RevealToolbar/Help/MenuSection.tsx Outdated Show resolved Hide resolved
react-components/src/components/RevealToolbar/HelpButton.tsx Outdated Show resolved Hide resolved
@pramodcog
positioned help screen centered to button, resturctured graphics with…
e6f4cb2 
… help container and addressed review comments
haakonflatval-cognite
haakonflatval-cognite approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM 👍

@pramodcog pramodcog merged commit 8bdfb84 into master Aug 10, 2023
13 checks passed
@pramodcog pramodcog deleted the pramodcog/UX-979 branch August 10, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haakonflatval-cognite haakonflatval-cognite haakonflatval-cognite approved these changes

@deep-cognite deep-cognite Awaiting requested review from deep-cognite

Assignees
No one assigned
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pramodcog @deep-cognite @haakonflatval-cognite