Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make FDM config non-required in 3DResources #3550

Merged
merged 4 commits into from
Aug 4, 2023
Merged

fix: make FDM config non-required in 3DResources #3550

merged 4 commits into from
Aug 4, 2023

Conversation

haakonflatval-cognite
Copy link
Contributor

Type of change

Bug

Jira ticket 📘

https://cognitedata.atlassian.net/browse/

Description 📝

To facilitate CDF-only usage too.
Will throw error when trying to use FDM without config.

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite
fix: make FDM config non-required in 3DResources
daed121 
To facilitate CDF-only usage too
@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner August 4, 2023 13:00
Savokr
Savokr previously approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@Savokr Savokr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@haakonflatval-cognite haakonflatval-cognite enabled auto-merge (squash) August 4, 2023 13:30
@haakonflatval-cognite haakonflatval-cognite added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Aug 4, 2023
Savokr
Savokr approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@Savokr Savokr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haakonflatval-cognite haakonflatval-cognite merged commit 4e20903 into master Aug 4, 2023
13 checks passed
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/optional-fdm-config branch August 4, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Savokr Savokr Savokr approved these changes

Assignees
No one assigned
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haakonflatval-cognite @Savokr