Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: viewer anchor adjustments #3546

Merged
merged 7 commits into from
Aug 4, 2023

Conversation

haakonflatval-cognite
Copy link
Contributor

Type of change

Bug

Jira ticket 📘

https://cognitedata.atlassian.net/browse/

Description 📝

Fix two small issues with ViewerAnchor:

  • Make it appear on first render
  • Suppress events targeting the viewer anchor

NB: This causes another issue - the "ViewerAnchor" div will still be present in the DOM at its original position, even though the child component may have been translated. They will both suppress events, even if the parent is invisible.

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite added the slack PRs and issues with this label will be pushed to Slack label Aug 3, 2023
@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner August 3, 2023 12:56
@haakonflatval-cognite haakonflatval-cognite changed the title Hflatval/viewer anchor adjustments fix: viewer anchor adjustments Aug 3, 2023
christjt
christjt previously approved these changes Aug 4, 2023
Avoids some messing-up when pointer is pressed on canvas and released
on a suppressing overlay
@haakonflatval-cognite haakonflatval-cognite enabled auto-merge (squash) August 4, 2023 08:39
@haakonflatval-cognite haakonflatval-cognite merged commit bfc25db into master Aug 4, 2023
13 checks passed
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/viewer-anchor-adjustments branch August 4, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants