Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: layer button component bugs #3540

Merged
merged 15 commits into from
Aug 3, 2023

Conversation

pramodcog
Copy link
Contributor

Type of change

Bug

Jira ticket 📘

https://cognitedata.atlassian.net/browse/UX-1126

Description 📝

Bug fixes listed in UX-1126 and some more edge cases handled

Example._.Toolbar._.LayersContainer.-.Docs.Storybook.-.Google.Chrome.2023-08-01.16-31-20.mp4

How has this been tested? 🔍

In Storybook

Test instructions ℹ️

cd react-components && yarn && yarn storybook
Select LayersContainer example

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@pramodcog pramodcog added auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack labels Aug 1, 2023
@pramodcog pramodcog requested a review from a team as a code owner August 1, 2023 14:33
Copy link
Contributor

@christjt christjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug1: Camera resets when toggling 360 !?!?!?

Bug2: Initial time when opening the side panel a double click is needed to select / deselect

Bug3 (from your video): There is something wrong when hovering
image

Probably bug: Fit camera to models button should only fit to visible models.

Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Christopher already gave you a big list of things to do 😅 I'll just add some nitpick:

  • When inside a 360 image and toggling only that 360 set, the viewer does not exit that image
  • Still feel like it should be possible to deduplicate the code across layer buttons 🤔 Something along the lines of wrapping every model in types implementing a common interface to get/set toggle etc. But not necessary for this PR

@pramodcog
Copy link
Contributor Author

Bug1: Camera resets when toggling 360 !?!?!?

Bug2: Initial time when opening the side panel a double click is needed to select / deselect

Bug3 (from your video): There is something wrong when hovering image

Probably bug: Fit camera to models button should only fit to visible models.

Bug 2 & 3 are related to cogs.js library, have connected & communicated to the team

Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Apart from the cogs.js-issues, at least :P

Copy link
Contributor

@christjt christjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more minor comments

Copy link
Contributor

@christjt christjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have the "needing to double click" first time issue. But I'll assume you will follow this up. Other than that, it looks good.

@pramodcog
Copy link
Contributor Author

I still have the "needing to double click" first time issue. But I'll assume you will follow this up. Other than that, it looks good.

It is bug in cogs.js, the CDS team have acknowledge the bug, will follow up on it

Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pramodcog pramodcog enabled auto-merge (squash) August 3, 2023 07:30
@pramodcog pramodcog merged commit 0426dcc into master Aug 3, 2023
13 checks passed
@pramodcog pramodcog deleted the pramodcog/fix-layer-button-component branch August 3, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants