-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Info card overlay #3521
feat: Info card overlay #3521
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally good. Wondering if it would be better to just have a <3DLabel> component that just uses Reveal to transform a the position of itself (and then implicitly its children), which would then not make it nessesary to use the DivProvider thing, and generally perhaps be a little simpler. I am accepting this for the sake of speed though, but I will try to make a short POC to see if it actually is simpler or not.
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/UX-1137
Description 📝
Create React component which users may use for including floating "info card".
How has this been tested? 🔍
Test instructions ℹ️
Checklist ☑️