-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: throw error if FDM config not provided when using FDM #3516
Merged
haakonflatval-cognite
merged 11 commits into
master
from
hflatval/make-config-mandatory
Jul 31, 2023
Merged
feat: throw error if FDM config not provided when using FDM #3516
haakonflatval-cognite
merged 11 commits into
master
from
hflatval/make-config-mandatory
Jul 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haakonflatval-cognite
added
the
slack
PRs and issues with this label will be pushed to Slack
label
Jul 26, 2023
haakonflatval-cognite
changed the title
feat: make config mandatory
feat: throw error if FDM config not provided when using FDM
Jul 27, 2023
haakonflatval-cognite
added
the
auto-update
Makes bulldozer automatically update this PR when there are changes to the target branch
label
Jul 31, 2023
Savokr
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-update
Makes bulldozer automatically update this PR when there are changes to the target branch
slack
PRs and issues with this label will be pushed to Slack
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/
Description 📝
Make the DMS config in React components required, so that it must be kept up-to-date with corresponding FDM interaction happening outside of React components.
EDIT: Instead of requiring it, throw error when trying to use it in FDM query. This allows us to not specify the config when we are not using FDM, but e.g. the asset centric model.
How has this been tested? 🔍
Test instructions ℹ️
Checklist ☑️