Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 3D Resources layering react component #3495

Merged
merged 32 commits into from
Jul 24, 2023
Merged

feat: 3D Resources layering react component #3495

merged 32 commits into from
Jul 24, 2023

Conversation

pramodcog
Copy link
Contributor

@pramodcog pramodcog commented Jul 18, 2023 •
edited
Loading

Type of change

Feat

Jira ticket 📘

https://cognitedata.atlassian.net/browse/UX-958

Description 📝

Allows the user to toggle visibility of 3D resources of CAD, point cloud & 360 images

Note: Opacity option is not added as Cad, point-cloud interface from Reveal does not support opacity feature

How has this been tested? 🔍

In storybook

Test instructions ℹ️

cd react-compnents && yarn && yarn build && yarn storybook
Select Toolbar/LayerContainer and click on Layers Icon

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@pramodcog pramodcog marked this pull request as ready for review July 19, 2023 10:00
@pramodcog pramodcog requested a review from a team as a code owner July 19, 2023 10:00
@pramodcog pramodcog added auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack labels Jul 19, 2023
@pramodcog pramodcog changed the title feat: 3D Layer react component feat: 3D Resources layering react component Jul 19, 2023
Savokr
Savokr suggested changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@Savokr Savokr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works really good but some additional work is required on styling front.

react-components/src/components/RevealToolbar/LayersContainer/CadModelLayersContainer.tsx Outdated Show resolved Hide resolved
react-components/src/components/RevealToolbar/LayersContainer/PointCloudLayersContainer.tsx Outdated Show resolved Hide resolved
react-components/src/components/RevealToolbar/LayersContainer/LayersContainer.tsx Outdated Show resolved Hide resolved
react-components/src/components/RevealToolbar/LayersContainer/LayersContainer.tsx Outdated Show resolved Hide resolved
react-components/src/components/RevealToolbar/LayersContainer/CadModelLayersContainer.tsx Outdated Show resolved Hide resolved
react-components/src/components/RevealToolbar/LayersContainer/CadModelLayersContainer.tsx Outdated Show resolved Hide resolved
react-components/src/components/RevealToolbar/LayersContainer/CadModelLayersContainer.tsx Outdated Show resolved Hide resolved
react-components/src/components/RevealToolbar/LayersContainer/LayersContainer.tsx Show resolved Hide resolved
react-components/src/components/RevealToolbar/LayersContainer/elements.ts Outdated Show resolved Hide resolved
pramodcog and others added 3 commits July 20, 2023 14:29
@pramodcog @Savokr
Update react-components/src/components/RevealToolbar/LayersContainer/…
84253c9 
…elements.ts

Co-authored-by: Savelii Novikov <45129444+Savokr@users.noreply.github.com>
@pramodcog @Savokr
Update react-components/src/components/RevealToolbar/LayersContainer/…
9ca0c2f 
…LayersContainer.tsx

Co-authored-by: Savelii Novikov <45129444+Savokr@users.noreply.github.com>
@pramodcog @Savokr
Update react-components/src/components/RevealToolbar/LayersContainer/…
b4b0b6d 
…LayersContainer.tsx

Co-authored-by: Savelii Novikov <45129444+Savokr@users.noreply.github.com>
@pramodcog pramodcog requested a review from Savokr July 21, 2023 11:14
Savokr
Savokr previously approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@Savokr Savokr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and feels really good! Small comment about colors on the counter.

react-components/src/components/RevealToolbar/LayersContainer/elements.ts Outdated Show resolved Hide resolved
react-components/src/components/RevealToolbar/LayersContainer/CadModelLayersContainer.tsx Outdated Show resolved Hide resolved
cognite-bulldozer bot and others added 2 commits July 24, 2023 06:14
@cognite-bulldozer
Merge refs/heads/master into pramodcog/UX-958
6f7e5ab
@pramodcog @deep-cognite
Update react-components/src/components/RevealToolbar/LayersContainer/…
c0c608c 
…CadModelLayersContainer.tsx

Co-authored-by: Deep <70804363+deep-cognite@users.noreply.github.com>
pramodcog and others added 4 commits July 24, 2023 09:48
@pramodcog @Savokr
Update react-components/src/components/RevealToolbar/LayersContainer/…
3adb0b5 
…elements.ts

Co-authored-by: Savelii Novikov <45129444+Savokr@users.noreply.github.com>
@pramodcog @Savokr
Update react-components/src/components/RevealToolbar/LayersContainer/…
a79d324 
…CadModelLayersContainer.tsx

Co-authored-by: Savelii Novikov <45129444+Savokr@users.noreply.github.com>
@pramodcog @deep-cognite
Update react-components/src/components/RevealToolbar/LayersContainer/…
a953a95 
…Image360LayersContainer.tsx

Co-authored-by: Deep <70804363+deep-cognite@users.noreply.github.com>
@pramodcog @deep-cognite
Update react-components/src/hooks/use3DModelName.tsx
3a34e4c 
Co-authored-by: Deep <70804363+deep-cognite@users.noreply.github.com>
deep-cognite
deep-cognite previously approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@deep-cognite deep-cognite left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gj! let's merge this and we can fine tune in the future :)

haakonflatval-cognite
haakonflatval-cognite previously approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pramodcog pramodcog merged commit a4be2db into master Jul 24, 2023
13 checks passed
@pramodcog pramodcog deleted the pramodcog/UX-958 branch July 24, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haakonflatval-cognite haakonflatval-cognite haakonflatval-cognite approved these changes

@Savokr Savokr Savokr left review comments

@deep-cognite deep-cognite deep-cognite left review comments

Assignees
No one assigned
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pramodcog @Savokr @deep-cognite @haakonflatval-cognite