Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: slice button for RevealToolbar #3492

Merged
merged 8 commits into from
Jul 21, 2023

Conversation

haakonflatval-cognite
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite commented Jul 17, 2023

Type of change

Feat

Jira ticket 📘

https://cognitedata.atlassian.net/browse/UX-977

Description 📝

Implements a button with a slider that allows the user to control the clipping planes in the height (y-axis) of the Reveal viewer. Scale is automatically adjusted to the models included in the scene.

Loosely based on the slicer in Data Explorer.

How has this been tested? 🔍

In storybook

Test instructions ℹ️

yarn storybook and look at the Toolbar tab.

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite added the slack PRs and issues with this label will be pushed to Slack label Jul 17, 2023
@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner July 17, 2023 13:43
pramodcog
pramodcog previously approved these changes Jul 21, 2023
Copy link
Contributor

@pramodcog pramodcog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@haakonflatval-cognite haakonflatval-cognite enabled auto-merge (squash) July 21, 2023 10:26
@haakonflatval-cognite haakonflatval-cognite enabled auto-merge (squash) July 21, 2023 10:26
@haakonflatval-cognite haakonflatval-cognite added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Jul 21, 2023
Copy link
Contributor

@pramodcog pramodcog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved again!

@haakonflatval-cognite haakonflatval-cognite merged commit ac23907 into master Jul 21, 2023
13 checks passed
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/toolbar-slice-button branch July 21, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants