Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-components): implement styling capability for 3D resources component and models containers #3485

Merged
merged 31 commits into from
Jul 17, 2023

Conversation

Savokr
Copy link
Contributor

@Savokr Savokr commented Jul 12, 2023

Type of change

Feat

Jira ticket 📘

https://cognitedata.atlassian.net/browse/UX-849

Description 📝

This PR adds styling property to all models components allowing to specify styling of 3d models based on externalIds of equipment in your data model or directly on the model using nodeId/TreeIndex or annotationId in point cloud case. It also introduces a simple utility for Reveal examples that allows you to create test annotations on point cloud models.

How has this been tested? 🔍

In storybook with different styling options provided.

Test instructions ℹ️

  1. Open 3D resources component in storybook and change different styling options available.
  2. Open Cad model / Point cloud model components and change different styling options there.

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@Savokr Savokr added auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack labels Jul 12, 2023
@Savokr Savokr requested a review from a team as a code owner July 12, 2023 09:19
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@0feb1c1). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3485   +/-   ##
=========================================
  Coverage          ?   71.67%           
=========================================
  Files             ?      346           
  Lines             ?    33669           
  Branches          ?     2643           
=========================================
  Hits              ?    24131           
  Misses            ?     9434           
  Partials          ?      104           

Copy link
Contributor

@pramodcog pramodcog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but we should revisit on my comments in future.

@Savokr Savokr merged commit 5dedfc3 into master Jul 17, 2023
14 checks passed
@Savokr Savokr deleted the savokr/react-styling-components branch July 17, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants