-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-components): implement styling capability for 3D resources component and models containers #3485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into christjt/UX-847
Savokr
added
auto-update
Makes bulldozer automatically update this PR when there are changes to the target branch
slack
PRs and issues with this label will be pushed to Slack
labels
Jul 12, 2023
Savokr
commented
Jul 12, 2023
Codecov Report
@@ Coverage Diff @@
## master #3485 +/- ##
=========================================
Coverage ? 71.67%
=========================================
Files ? 346
Lines ? 33669
Branches ? 2643
=========================================
Hits ? 24131
Misses ? 9434
Partials ? 104 |
pramodcog
reviewed
Jul 12, 2023
pramodcog
reviewed
Jul 12, 2023
pramodcog
reviewed
Jul 12, 2023
pramodcog
reviewed
Jul 12, 2023
pramodcog
reviewed
Jul 12, 2023
pramodcog
reviewed
Jul 12, 2023
pramodcog
reviewed
Jul 12, 2023
pramodcog
reviewed
Jul 12, 2023
pramodcog
reviewed
Jul 12, 2023
pramodcog
reviewed
Jul 12, 2023
pramodcog
reviewed
Jul 12, 2023
pramodcog
reviewed
Jul 12, 2023
pramodcog
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but we should revisit on my comments in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-update
Makes bulldozer automatically update this PR when there are changes to the target branch
slack
PRs and issues with this label will be pushed to Slack
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/UX-849
Description 📝
This PR adds
styling
property to all models components allowing to specify styling of 3d models based onexternalId
s of equipment in your data model or directly on the model usingnodeId
/TreeIndex
orannotationId
in point cloud case. It also introduces a simple utility for Reveal examples that allows you to create test annotations on point cloud models.How has this been tested? 🔍
In storybook with different styling options provided.
Test instructions ℹ️
Checklist ☑️