Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing redraw on Image Icon Visibility change #3469

Merged

Conversation

Strepto
Copy link
Contributor

@Strepto Strepto commented Jul 6, 2023

Type of change

Bug

Jira ticket 📘

N/A

Description 📝

When toggling image visibility there is no redraw after the fix in #3463. This adds a forced redraw after the image visibility is changed.

There may still be more issues with _needsRedraw, but most of the interactions with 360 images from the 360ImageApi manages this correctly. Will add more PRs as I find stuff :)

How has this been tested? 🔍

N/A

Test instructions ℹ️

Toggle a image collection visibility without any movement. Images should dissappear and reappear.

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@Strepto Strepto requested a review from a team as a code owner July 6, 2023 11:35
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #3469 (7845a62) into master (15a4389) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3469      +/-   ##
==========================================
- Coverage   71.67%   71.66%   -0.01%     
==========================================
  Files         346      346              
  Lines       33668    33669       +1     
  Branches     2643     2644       +1     
==========================================
- Hits        24131    24129       -2     
- Misses       9433     9436       +3     
  Partials      104      104              
Impacted Files Coverage Δ
...images/src/collection/DefaultImage360Collection.ts 56.69% <0.00%> (-0.21%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Contributor

@christjt christjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@christjt christjt merged commit 760323a into cognitedata:master Jul 6, 2023
14 checks passed
@Strepto Strepto deleted the nih/fix/redraw-on-visibility-changed branch July 6, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants