Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-components): add threed resource container #3451

Merged
merged 15 commits into from
Jul 4, 2023
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions react-components/.eslintrc.cjs
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
const path = require('path');

module.exports = {
env: {
browser: true,
Expand All @@ -14,7 +12,8 @@ module.exports = {
parserOptions: {
ecmaVersion: 'latest',
sourceType: 'module',
project: [path.join(__dirname, 'tsconfig.json')]
project: './tsconfig.json',
tsconfigRootDir: __dirname
},
plugins: ['react', 'prettier', 'header'],
rules: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,22 @@ import { type Matrix4 } from 'three';
type Cognite3dModelProps = {
addModelOptions: AddModelOptions;
transform?: Matrix4;
onLoad?: () => void;
};

export default function CogniteCadModelContainer({
export default function CadModelContainer({
addModelOptions,
transform
transform,
onLoad
}: Cognite3dModelProps): ReactElement {
const modelRef = useRef<CogniteCadModel>();
const viewer = useReveal();
const { modelId, revisionId } = addModelOptions;
const { modelId, revisionId, geometryFilter } = addModelOptions;

useEffect(() => {
addModel(modelId, revisionId, transform).catch(console.error);
addModel(modelId, revisionId, transform, onLoad).catch(console.error);
return removeModel;
}, [addModelOptions]);
}, [modelId, revisionId, geometryFilter]);

useEffect(() => {
if (modelRef.current === undefined || transform === undefined) return;
Expand All @@ -31,12 +33,18 @@ export default function CogniteCadModelContainer({

return <></>;

async function addModel(modelId: number, revisionId: number, transform?: Matrix4): Promise<void> {
async function addModel(
modelId: number,
revisionId: number,
transform?: Matrix4,
onLoad?: () => void
): Promise<void> {
const cadModel = await viewer.addCadModel({ modelId, revisionId });
if (transform !== undefined) {
cadModel.setModelTransformation(transform);
}
modelRef.current = cadModel;
onLoad?.();
}

function removeModel(): void {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
/*!
* Copyright 2023 Cognite AS
*/
import { type ReactElement, useEffect, useContext, useRef } from 'react';
import { useReveal } from '../RevealContainer/RevealContext';
import { ModelsLoadingStateContext } from '../Reveal3DResources/ModelsLoadingContext';
import { type CameraState } from '@cognite/reveal';

export type CameraControllerProps = {
initialFitCamera?: { to: 'allModels' } | { to: 'cameraState'; state: CameraState };
};

export function CameraController({ initialFitCamera }: CameraControllerProps): ReactElement {
const initialCameraSet = useRef(false);
const viewer = useReveal();
const { modelsAdded } = useContext(ModelsLoadingStateContext);

useEffect(() => {
if (initialCameraSet.current) return;
if (initialFitCamera === undefined) {
initialCameraSet.current = true;
return;
christjt marked this conversation as resolved.
Show resolved Hide resolved
}
if (initialFitCamera.to === 'cameraState') {
viewer.cameraManager.setCameraState(initialFitCamera.state);
initialCameraSet.current = true;
return;
}
if (initialFitCamera.to === 'allModels' && modelsAdded) {
viewer.fitCameraToModels(viewer.models, 0, true);
initialCameraSet.current = true;
}
}, [modelsAdded]);

return <></>;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
/*!
* Copyright 2023 Cognite AS
*/
import { type ReactElement, useEffect, useRef } from 'react';
import { useReveal } from '../RevealContainer/RevealContext';
import { type Image360Collection } from '@cognite/reveal';

type Image360CollectionContainerProps = {
siteId: string;
onLoad?: () => void;
};

export function Image360CollectionContainer({
siteId,
onLoad
}: Image360CollectionContainerProps): ReactElement {
const modelRef = useRef<Image360Collection>();
const viewer = useReveal();

useEffect(() => {
addModel().catch(console.error);
return removeModel;
}, [siteId]);

return <></>;

async function addModel(): Promise<void> {
christjt marked this conversation as resolved.
Show resolved Hide resolved
const image360Collection = await viewer.add360ImageSet('events', { site_id: siteId });
modelRef.current = image360Collection;
onLoad?.();
}

function removeModel(): void {
if (modelRef.current === undefined) return;
viewer.remove360ImageSet(modelRef.current);
modelRef.current = undefined;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
/*!
* Copyright 2023 Cognite AS
*/

import { type CognitePointCloudModel, type AddModelOptions } from '@cognite/reveal';
import { useEffect, useRef, type ReactElement } from 'react';
import { type Matrix4 } from 'three';
import { useReveal } from '../RevealContainer/RevealContext';

type Cognite3dModelProps = {
addModelOptions: AddModelOptions;
transform?: Matrix4;
onLoad?: () => void;
};

export default function PointCloudContainer({
addModelOptions,
transform,
onLoad
}: Cognite3dModelProps): ReactElement {
const modelRef = useRef<CognitePointCloudModel>();
const viewer = useReveal();
const { modelId, revisionId } = addModelOptions;

useEffect(() => {
addModel(modelId, revisionId, transform).catch(console.error);
return removeModel;
}, [modelId, revisionId]);

useEffect(() => {
if (modelRef.current === undefined || transform === undefined) return;
modelRef.current.setModelTransformation(transform);
}, [transform]);

return <></>;

async function addModel(modelId: number, revisionId: number, transform?: Matrix4): Promise<void> {
const pointCloudModel = await viewer.addPointCloudModel({ modelId, revisionId });
if (transform !== undefined) {
pointCloudModel.setModelTransformation(transform);
}
modelRef.current = pointCloudModel;
onLoad?.();
}

function removeModel(): void {
if (modelRef.current === undefined || !viewer.models.includes(modelRef.current)) return;
viewer.removeModel(modelRef.current);
modelRef.current = undefined;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
/*!
* Copyright 2023 Cognite AS
*/
import { createContext } from 'react';

export type ModelsLoadingState = {
modelsAdded: boolean;
setModelsAdded: (value: boolean) => void;
};
export const ModelsLoadingStateContext = createContext<ModelsLoadingState>({
modelsAdded: false,
setModelsAdded: () => {}
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,103 @@
/*!
* Copyright 2023 Cognite AS
*/
import { useRef, type ReactElement, useContext, useState, useEffect } from 'react';
import { type Cognite3DViewer } from '@cognite/reveal';
import { ModelsLoadingStateContext } from './ModelsLoadingContext';
import CadModelContainer from '../CadModelContainer/CadModelContainer';
import PointCloudContainer from '../PointCloudContainer/PointCloudContainer';
import { Image360CollectionContainer } from '../Image360CollectionContainer/Image360CollectionContainer';
import { useReveal } from '../RevealContainer/RevealContext';
import {
type AddReveal3DModelOptions,
type AddImageCollection360Options,
type TypedReveal3DModel,
type AddResourceOptions
} from './types';

export type Reveal3DResourcesProps = {
resources: AddResourceOptions[];
};

export const Reveal3DResources = ({ resources }: Reveal3DResourcesProps): ReactElement => {
const [reveal3DModels, setReveal3DModels] = useState<TypedReveal3DModel[]>([]);
const { setModelsAdded } = useContext(ModelsLoadingStateContext);
const viewer = useReveal();
const numModelsLoaded = useRef(0);

useEffect(() => {
getTypedModels(resources, viewer).then(setReveal3DModels).catch(console.error);
}, []);
christjt marked this conversation as resolved.
Show resolved Hide resolved

const image360CollectionAddOptions = resources.filter(
(resource): resource is AddImageCollection360Options =>
(resource as AddImageCollection360Options).siteId !== undefined
);

const onModelLoaded = (): void => {
numModelsLoaded.current += 1;
if (numModelsLoaded.current === resources.length) {
setModelsAdded(true);
}
};

return (
<>
{reveal3DModels
.filter(({ type }) => type === 'cad')
.map((addModelOption) => {
return (
<CadModelContainer
key={`${addModelOption.modelId}/${addModelOption.revisionId}`}
christjt marked this conversation as resolved.
Show resolved Hide resolved
addModelOptions={addModelOption}
transform={addModelOption.transform}
onLoad={onModelLoaded}
/>
);
})}
{reveal3DModels
.filter(({ type }) => type === 'pointcloud')
.map((addModelOption) => {
return (
<PointCloudContainer
key={`${addModelOption.modelId}/${addModelOption.revisionId}`}
addModelOptions={addModelOption}
transform={addModelOption.transform}
onLoad={onModelLoaded}
/>
);
})}
{image360CollectionAddOptions.map((addModelOption) => {
return (
<Image360CollectionContainer
key={`${addModelOption.siteId}`}
siteId={addModelOption.siteId}
onLoad={onModelLoaded}
/>
);
})}
</>
);
};

async function getTypedModels(
resources: AddResourceOptions[],
viewer: Cognite3DViewer
): Promise<TypedReveal3DModel[]> {
return await Promise.all(
resources
.filter(
(resource): resource is AddReveal3DModelOptions =>
(resource as AddReveal3DModelOptions).modelId !== undefined &&
(resource as AddReveal3DModelOptions).revisionId !== undefined
)
.map(async (addModelOptions) => {
const type = await viewer.determineModelType(
addModelOptions.modelId,
addModelOptions.revisionId
);
const typedModel: TypedReveal3DModel = { ...addModelOptions, type };
return typedModel;
})
);
}
15 changes: 15 additions & 0 deletions react-components/src/components/Reveal3DResources/types.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
/*!
* Copyright 2023 Cognite AS
*/

import { type AddModelOptions, type SupportedModelTypes } from '@cognite/reveal';
import { type Matrix4 } from 'three';

export type AddImageCollection360Options = {
siteId: string;
};

export type AddResourceOptions = AddReveal3DModelOptions | AddImageCollection360Options;

export type AddReveal3DModelOptions = AddModelOptions & { transform?: Matrix4 };
export type TypedReveal3DModel = AddReveal3DModelOptions & { type: SupportedModelTypes | '' };
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { useEffect, useRef, type ReactNode, useState, type ReactElement } from '
import { Cognite3DViewer } from '@cognite/reveal';
import { RevealContext } from './RevealContext';
import { type Color } from 'three';
import { ModelsLoadingStateContext } from '../Reveal3DResources/ModelsLoadingContext';

type RevealContainerProps = {
color?: Color;
Expand Down Expand Up @@ -36,7 +37,9 @@ export default function RevealContainer({
if (viewer === undefined) return <></>;
return (
<>
<RevealContext.Provider value={viewer}>{children}</RevealContext.Provider>
<RevealContext.Provider value={viewer}>
<ModelsLoadingProvider>{children}</ModelsLoadingProvider>
</RevealContext.Provider>
</>
);
}
Expand All @@ -57,3 +60,13 @@ export default function RevealContainer({
setViewer(undefined);
}
}

function ModelsLoadingProvider({ children }: { children?: ReactNode }): ReactElement {
const [modelsLoading, setModelsLoading] = useState(false);
return (
<ModelsLoadingStateContext.Provider
value={{ modelsAdded: modelsLoading, setModelsAdded: setModelsLoading }}>
{children}
</ModelsLoadingStateContext.Provider>
);
}
7 changes: 0 additions & 7 deletions react-components/src/components/index.ts

This file was deleted.

17 changes: 16 additions & 1 deletion react-components/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,19 @@
/*!
* Copyright 2023 Cognite AS
*/
export * from './components';
import '@cognite/cogs.js/dist/cogs.css';
export { default as RevealContainer } from './components/RevealContainer/RevealContainer';
export { default as PointCloudContainer } from './components/PointCloudContainer/PointCloudContainer';
export { default as CadModelContainer } from './components/CadModelContainer/CadModelContainer';
christjt marked this conversation as resolved.
Show resolved Hide resolved
export { Image360CollectionContainer } from './components/Image360CollectionContainer/Image360CollectionContainer';
export { Image360HistoricalDetails } from './components/Image360HistoricalDetails/Image360HistoricalDetails';
export {
Reveal3DResources,
type Reveal3DResourcesProps
} from './components/Reveal3DResources/Reveal3DResources';
export { CameraController } from './components/CameraController/CameraController';
export type {
AddImageCollection360Options,
AddResourceOptions,
AddReveal3DModelOptions
} from './components/Reveal3DResources/types';
Loading
Loading