Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(reveal-react-components): add formatting and linting #3422

Merged
merged 34 commits into from
Jun 27, 2023

Conversation

christjt
Copy link
Contributor

Type of change

Chore

Description 📝

Add prettier and eslint for formatting and linting

@christjt christjt added auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack labels Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #3422 (f39b162) into master (f6554e1) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3422   +/-   ##
=======================================
  Coverage   71.53%   71.53%           
=======================================
  Files         344      344           
  Lines       33235    33235           
  Branches     2580     2582    +2     
=======================================
+ Hits        23773    23775    +2     
+ Misses       9358     9356    -2     
  Partials      104      104           

see 1 file with indirect coverage changes

@christjt christjt marked this pull request as ready for review June 26, 2023 14:34
@christjt christjt requested a review from a team as a code owner June 26, 2023 14:34
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mostly 👍

@christjt christjt enabled auto-merge (squash) June 27, 2023 07:55
@christjt christjt merged commit caa598f into master Jun 27, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants