-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-components): add Reveal container and container for CogniteCadModel #3419
Conversation
…hristjt/reveal-container-test
There were failures in the visual tests workflow. |
Codecov Report
@@ Coverage Diff @@
## master #3419 +/- ##
==========================================
- Coverage 71.53% 71.53% -0.01%
==========================================
Files 344 344
Lines 33235 33229 -6
Branches 2582 2584 +2
==========================================
- Hits 23775 23770 -5
+ Misses 9356 9355 -1
Partials 104 104 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 A few remarks, but not necessary to address them all. I think we can afford to iterate fast on this package, at least now in the beginning
react-components/src/components/CogniteCadModelContainer/CogniteCadModelContainer.tsx
Outdated
Show resolved
Hide resolved
react-components/src/components/CogniteCadModelContainer/CogniteCadModelContainer.tsx
Outdated
Show resolved
Hide resolved
react-components/src/components/CogniteCadModelContainer/CogniteCadModelContainer.tsx
Outdated
Show resolved
Hide resolved
react-components/src/stories/CogniteCadModelContainer.stories.tsx
Outdated
Show resolved
Hide resolved
…ognitedata/reveal into christjt/reveal-container-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM again 👍
Type of change
Description 📝
Adds react containers for reveal and cognitecadmodel.
Test instructions ℹ️
Start storybook and click the CogniteCadModel component. Append
&token=...
with a token from 3d-test to the URL.Checklist ☑️