Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-components): add Reveal container and container for CogniteCadModel #3419

Merged
merged 14 commits into from
Jun 26, 2023

Conversation

christjt
Copy link
Contributor

@christjt christjt commented Jun 26, 2023

Type of change

Feat

Description 📝

Adds react containers for reveal and cognitecadmodel.

Test instructions ℹ️

Start storybook and click the CogniteCadModel component. Append &token=... with a token from 3d-test to the URL.

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@christjt christjt added auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack labels Jun 26, 2023
@christjt christjt requested a review from a team as a code owner June 26, 2023 07:56
@github-actions
Copy link

There were failures in the visual tests workflow.
Image diffs for visual tests can be downloaded as an artifact here.

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #3419 (69efdca) into master (e240496) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 69efdca differs from pull request most recent head c70cbbc. Consider uploading reports for the commit c70cbbc to get more accurate results

@@            Coverage Diff             @@
##           master    #3419      +/-   ##
==========================================
- Coverage   71.53%   71.53%   -0.01%     
==========================================
  Files         344      344              
  Lines       33235    33229       -6     
  Branches     2582     2584       +2     
==========================================
- Hits        23775    23770       -5     
+ Misses       9356     9355       -1     
  Partials      104      104              

see 3 files with indirect coverage changes

Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 A few remarks, but not necessary to address them all. I think we can afford to iterate fast on this package, at least now in the beginning

@christjt christjt enabled auto-merge (squash) June 26, 2023 13:15
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again 👍

@christjt christjt merged commit f8581af into master Jun 26, 2023
10 checks passed
@christjt christjt deleted the christjt/reveal-container-test branch June 26, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants