Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: seed SSAO kernel generation to avoid flaky SSAO visual test #3415

Merged
merged 6 commits into from
Jun 26, 2023

Conversation

haakonflatval-cognite
Copy link
Contributor

Type of change

Chore

Jira ticket 📘

https://cognitedata.atlassian.net/browse/

Description 📝

Seeding SSAO to avoid flaky visual test

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite added the slack PRs and issues with this label will be pushed to Slack label Jun 23, 2023
@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner June 23, 2023 14:50
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #3415 (cb4c78b) into master (97796ca) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3415   +/-   ##
=======================================
  Coverage   71.52%   71.53%           
=======================================
  Files         344      344           
  Lines       33229    33232    +3     
  Branches     2582     2583    +1     
=======================================
+ Hits        23768    23771    +3     
  Misses       9357     9357           
  Partials      104      104           
Impacted Files Coverage Δ
...r/packages/rendering/src/render-passes/SSAOPass.ts 90.21% <100.00%> (+0.32%) ⬆️

@haakonflatval-cognite haakonflatval-cognite enabled auto-merge (squash) June 26, 2023 09:32
@haakonflatval-cognite haakonflatval-cognite added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Jun 26, 2023
@haakonflatval-cognite haakonflatval-cognite merged commit 65c4001 into master Jun 26, 2023
11 checks passed
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/seed-ssao-generation branch June 26, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants