-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix lib-check errors in examples #3370
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3370 +/- ##
=======================================
Coverage 71.52% 71.53%
=======================================
Files 344 344
Lines 33241 33241
Branches 2583 2585 +2
=======================================
+ Hits 23776 23778 +2
+ Misses 9361 9359 -2
Partials 104 104
|
9ca91cd
to
3faa744
Compare
📙 Documentation preview is available from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tracking this down! LGTM!
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/
Description 📝
Remove some lib check errors that have accumulated in our examples.
A recent fix in
ts-loader
allows us to overrideskipLibCheck
and set it tofalse
inexamples/tsconfig.json
. We have had it set tofalse
for a while, but it has had no effect. This was fixed in ts-loader v9.4.4.A couple of other changes have been made:
tsconfig.json
target
has been set toes6
. Before, it complained about theaccessor
keyword introduced in thePointCloudMaterial
code not too long ago.VariableWidthLine
was modified so as to not exposeLine2
fromthree
examples in its types, as it was not found byreveal/examples
in compile time. Still unsure of why that was.As a side-effect of the investigation, we have a theory that Reveal no longer supports being imported as CommonJS, because of the
sparse-octree
dependency which is ESM only.How has this been tested? 🔍
Test instructions ℹ️
Checklist ☑️