chore: be more strict in the add/remove-logic

It's a miracle this worked before
cognitedata · Sep 12, 2024 · e56a844 · e56a844
1 parent 06c687b
commit e56a844
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/react-components/src/components/CadModelContainer/CadModelContainer.tsx b/react-components/src/components/CadModelContainer/CadModelContainer.tsx
@@ -64,7 +64,7 @@ export function CadModelContainer({
 
   useApplyCadModelStyling(model, styling);
 
-  useEffect(() => removeModel, [model]);
+  useEffect(() => () => removeModel(model), [model]);
 
   return <></>;
 
@@ -96,15 +96,14 @@ export function CadModelContainer({
     }
   }
 
-  function removeModel(): void {
+  function removeModel(model: CogniteCadModel | undefined): void {
     if (!modelExists(model, viewer)) return;
 
     if (cachedViewerRef !== undefined && !cachedViewerRef.isRevealContainerMountedRef.current)
       return;
 
     viewer.removeModel(model);
     setRevealResourcesCount(getViewerResourceCount(viewer));
-    setModel(undefined);
   }
 }