Skip to content

Commit

Permalink
Smaller fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
nilscognite committed Aug 19, 2024
1 parent 3f66667 commit b96066d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export class MockFilterCommand extends BaseFilterCommand {

private _timeStamp: number | undefined = undefined;
private _useAllColor: boolean = true;
private readonly _testDynamic: boolean = false;
private readonly _testDynamic: boolean = false; // True to test dynamic updates (for testing purposes)

// ==================================================
// OVERRIDES
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export class PointCloudFilterCommand extends BaseFilterCommand {
super.initializeChildrenIfNeeded();
}

protected createChildren(): FilterItemCommand[] {
protected override createChildren(): FilterItemCommand[] {
const pointCloud = this.getPointCloud();
if (pointCloud === undefined) {
return [];
Expand All @@ -68,15 +68,15 @@ export class PointCloudFilterCommand extends BaseFilterCommand {
if (pointCloud === undefined) {
return false;
}
return isClassesVisible(pointCloud);
return isAllClassesVisible(pointCloud);
}

public override toggleAllChecked(): void {
const pointCloud = this.getPointCloud();
if (pointCloud === undefined) {
return;
}
const isAllChecked = isClassesVisible(pointCloud);
const isAllChecked = isAllClassesVisible(pointCloud);
const classes = pointCloud.getClasses();
if (classes === undefined || classes.length === 0) {
return;
Expand Down Expand Up @@ -214,7 +214,7 @@ function getFirstPointCloudWithClasses(
return undefined;
}

function isClassesVisible(pointCloud: CognitePointCloudModel): boolean {
function isAllClassesVisible(pointCloud: CognitePointCloudModel): boolean {
const classes = pointCloud.getClasses();
if (classes === undefined || classes.length === 0) {
return false;
Expand Down

0 comments on commit b96066d

Please sign in to comment.