renamed prop name, removed unnecessary additional component

cognitedata · Aug 26, 2024 · afd2097 · afd2097
1 parent 9ab65aa
commit afd2097
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/react-components/src/components/Widgets/WindowWidget.tsx b/react-components/src/components/Widgets/WindowWidget.tsx
@@ -27,7 +27,7 @@ type WindowWidgetProps = {
   subtitle?: string;
   header?: string;
   type?: string;
-  openInNewTab?: ReactNode;
+  customComponent?: ReactNode;
   children: ReactNode;
   onClose?: () => void;
   onResize?: (width: number, height: number) => void;
@@ -39,7 +39,7 @@ export const WindowWidget = ({
   header,
   type,
   children,
-  openInNewTab,
+  customComponent,
   onClose,
   onResize
 }: WindowWidgetProps): ReactElement => {
@@ -117,7 +117,7 @@ export const WindowWidget = ({
           onResize={handleResize}>
           <Widget>
             <Widget.Header title={title} type={type} header={header} subtitle={subtitle}>
-              {openInNewTab !== undefined && <div>{openInNewTab}</div>}
+              {customComponent !== undefined && customComponent}
               <CogsTooltip
                 content={
                   isMinimized

diff --git a/react-components/src/components/Widgets/constants.ts b/react-components/src/components/Widgets/constants.ts
@@ -6,6 +6,6 @@ export const WIDGET_WINDOW_X_OFFSET = 150;
 export const WIDGET_WINDOW_Y_OFFSET = 75;
 export const WIDGET_WIDTH_FACTOR = 0.4;
 export const WIDGET_HEIGHT_FACTOR = 0.7;
-export const WIDGET_WINDOW_MIN_WIDTH = 300;
+export const WIDGET_WINDOW_MIN_WIDTH = 400;
 export const WIDGET_WINDOW_MIN_HEIGHT = 48;
 export const WIDGET_INSIDE_WINDOW_MIN_HEIGHT = 150;
diff --git a/react-components/stories/SplitWindow.stories.tsx b/react-components/stories/SplitWindow.stories.tsx
@@ -49,7 +49,7 @@ export const Main: Story = {
               <WindowWidget
                 header="Widget Header"
                 onClose={handleClose}
-                openInNewTab={openExternalButton()}>
+                customComponent={openExternalButton()}>
                 <SecondaryRevealContainer />
               </WindowWidget>
             )}
@@ -61,7 +61,11 @@ export const Main: Story = {
 };
 
 function openExternalButton(): ReactNode {
-  return <Button>Open in New Tab</Button>;
+  return (
+    <Button style={{ whiteSpace: 'nowrap', overflow: 'hidden', textOverflow: 'ellipsis' }}>
+      Open in New Tab
+    </Button>
+  );
 }
 
 function SecondaryRevealContainer(): ReactElement {