fix: 'Examples' camera manager implementation

cognitedata · Jun 26, 2023 · 7991c19 · 7991c19
1 parent 68ce414
commit 7991c19
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/examples/src/utils/CustomCameraManager.ts b/examples/src/utils/CustomCameraManager.ts
@@ -48,7 +48,12 @@ export class CustomCameraManager implements CameraManager {
     const target =
       state.target ??
       (state.rotation
-        ? CameraManagerHelper.calculateNewTargetFromRotation(this._camera, state.rotation, this._controls.target)
+        ? CameraManagerHelper.calculateNewTargetFromRotation(
+            this._camera,
+            state.rotation,
+            this._controls.target,
+            position
+          )
         : this._controls.target);
 
     this._camera.position.copy(position);

diff --git a/viewer/packages/camera-manager/src/CameraManagerHelper.ts b/viewer/packages/camera-manager/src/CameraManagerHelper.ts
@@ -37,6 +37,7 @@ export class CameraManagerHelper {
    * @param camera Used camera instance.
    * @param rotation New camera rotation in quaternion form.
    * @param currentTarget Current camera target.
+   * @param position New camera position.
    * @returns
    */
   static calculateNewTargetFromRotation(