fix(react-components): fix duplicated timeseries in expressions (#4528)

* fix timeseries duplication when traversing mutliple expressions including with no timeseries

* cleanup

* refactoring based on cr

* naming

react-components/src/components/RuleBasedOutputs/utils.ts

@@ -43,12 +43,15 @@ const checkStringExpressionStatement = (
   const currentTriggerData = triggerTypeData.find(
     (triggerType) => triggerType.type === trigger?.type
   );
-  const assetTrigger =
+
+  const isMetadataAndAssetTrigger =
     trigger?.type === 'metadata' &&
     currentTriggerData?.type === 'metadata' &&
-    currentTriggerData?.asset !== undefined
-      ? currentTriggerData?.asset[trigger.type]?.[trigger.key]
-      : undefined;
+    currentTriggerData?.asset !== undefined;
+
+  const assetTrigger = isMetadataAndAssetTrigger
+    ? currentTriggerData?.asset[trigger.type]?.[trigger.key]
+    : undefined;
 
   if (assetTrigger === undefined) return;
 
@@ -439,10 +442,9 @@ const generateTimeseriesAndDatapointsFromTheAsset = ({
 export const traverseExpressionToGetTimeseries = (
   expressions: Expression[] | undefined
 ): string[] | undefined => {
-  let timeseriesExternalIdFound: string[] | undefined = [];
-
   const timeseriesExternalIdResults = expressions
     ?.map((expression) => {
+      let timeseriesExternalIdFound: string[] | undefined = [];
       switch (expression.type) {
         case 'or':
         case 'and': {
@@ -461,7 +463,6 @@ export const traverseExpressionToGetTimeseries = (
       return timeseriesExternalIdFound?.filter(isDefined) ?? [];
     })
     .flat();
-
   return timeseriesExternalIdResults;
 };