Update according to review

cognitedata · Aug 6, 2024 · 448d21e · 448d21e
1 parent 5f24ec6
commit 448d21e
Showing 1 changed file with 3 additions and 13 deletions.
diff --git a/react-components/src/architecture/base/commands/BaseFilterCommand.ts b/react-components/src/architecture/base/commands/BaseFilterCommand.ts
@@ -93,26 +93,16 @@ export abstract class BaseFilterCommand extends RenderTargetCommand {
     if (this._children === undefined) {
       return this.getNoneLabel(translate);
     }
-    let label = '';
-    let counter = 0;
-    for (const child of this._children) {
-      if (!child.isChecked) {
-        continue;
-      }
-      if (counter > 0) {
-        label = label.concat(', ');
-      }
-      label = label.concat(child.getLabel(translate));
-      counter++;
-    }
+    const selected = this._children.filter((child) => child.isChecked);
+    const counter = selected.length;
     if (counter === 0) {
       return this.getNoneLabel(translate);
     }
     if (counter === this._children.length) {
       return this.getAllLabel(translate);
     }
     if (counter === 1) {
-      return label;
+      return selected[0].getLabel(translate);
     }
     return counter.toString() + ' ' + this.getSelected(translate);
   }