fix: update reveal version

cognitedata · Jun 26, 2023 · 2100d01 · 2100d01
1 parent a20c401
commit 2100d01
Show file tree

Hide file tree

Showing 3 changed files with 494 additions and 25 deletions.
diff --git a/react-components/package.json b/react-components/package.json
@@ -26,7 +26,7 @@
     "@babel/preset-react": "7.22.5",
     "@babel/preset-typescript": "7.22.5",
     "@cognite/cogs.js": "^9.17.0",
-    "@cognite/reveal": "link:../viewer",
+    "@cognite/reveal": "4.3.4",
     "@cognite/sdk": "^8.2.0",
     "@storybook/addon-essentials": "7.0.22",
     "@storybook/addon-interactions": "7.0.22",

diff --git a/react-components/src/components/CogniteCadModelContainer/CogniteCadModelContainer.tsx b/react-components/src/components/CogniteCadModelContainer/CogniteCadModelContainer.tsx
@@ -1,5 +1,5 @@
-import { useEffect, useRef, useState } from "react";
-import { AddModelOptions, Cognite3DViewer, CogniteCadModel } from '@cognite/reveal';
+import { useEffect, useRef } from "react";
+import { AddModelOptions, CogniteCadModel } from '@cognite/reveal';
 import { useReveal } from "../RevealContainer/RevealContext";
 import { Matrix4 } from "three";
 
@@ -17,7 +17,7 @@ export default function CogniteCadModelContainer({ addModelOptions, transform }:
     addModel(modelId, revisionId, transform)
       .catch(console.error);
     return () => {
-      if (modelRef.current === undefined || (viewer as any).isDisposed) return;
+      if (modelRef.current === undefined || !viewer.models.includes(modelRef.current)) return;
       viewer.removeModel(modelRef.current);
       modelRef.current = undefined;
     }