fix: Camera target calculated from new position

cognitedata · Jun 26, 2023 · 02b22e5 · 02b22e5
1 parent 87e6f62
commit 02b22e5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/viewer/packages/camera-manager/src/CameraManagerHelper.ts b/viewer/packages/camera-manager/src/CameraManagerHelper.ts
@@ -42,7 +42,8 @@ export class CameraManagerHelper {
   static calculateNewTargetFromRotation(
     camera: THREE.PerspectiveCamera,
     rotation: THREE.Quaternion,
-    currentTarget: THREE.Vector3
+    currentTarget: THREE.Vector3,
+    position: THREE.Vector3
   ): THREE.Vector3 {
     const distToTarget = currentTarget.clone().sub(camera.position);
     const tempCam = camera.clone();
@@ -54,7 +55,7 @@ export class CameraManagerHelper {
       .getWorldDirection(new THREE.Vector3())
       .normalize()
       .multiplyScalar(distToTarget.length())
-      .add(tempCam.position);
+      .add(position);
 
     return newTarget;
   }

diff --git a/viewer/packages/camera-manager/src/DefaultCameraManager.ts b/viewer/packages/camera-manager/src/DefaultCameraManager.ts
@@ -212,7 +212,8 @@ export class DefaultCameraManager implements CameraManager {
         ? CameraManagerHelper.calculateNewTargetFromRotation(
             this._camera,
             state.rotation,
-            this._controls.getState().target
+            this._controls.getState().target,
+            newPosition
           )
         : this._controls.getState().target);