Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: initial assets uploader queue #230

Merged
merged 7 commits into from
Jul 14, 2023
Merged

feat: initial assets uploader queue #230

merged 7 commits into from
Jul 14, 2023

Conversation

toondaey
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 14, 2023 •
edited
Loading

Codecov Report

Merging #230 (eb32437) into master (3471700) will increase coverage by 0.45%.
The diff coverage is 91.54%.

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
+ Coverage   78.73%   79.18%   +0.45%     
==========================================
  Files          21       22       +1     
  Lines        1876     1946      +70     
==========================================
+ Hits         1477     1541      +64     
- Misses        399      405       +6
Impacted Files Coverage Δ
cognite/extractorutils/uploader/events.py 92.30% <ø> (+1.13%) ⬆️
cognite/extractorutils/uploader/_base.py 91.52% <50.00%> (-1.46%) ⬇️
cognite/extractorutils/uploader/assets.py 92.18% <92.18%> (ø)
cognite/extractorutils/uploader/__init__.py 100.00% <100.00%> (ø)
cognite/extractorutils/uploader/_metrics.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@toondaey toondaey marked this pull request as ready for review July 14, 2023 08:07
@toondaey toondaey requested a review from a team as a code owner July 14, 2023 08:07
ozangoktan
ozangoktan reviewed Jul 14, 2023
View reviewed changes
Copy link
Contributor

@ozangoktan ozangoktan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few typos we should fix

cognite/extractorutils/uploader/_metrics.py Outdated Show resolved Hide resolved
cognite/extractorutils/uploader/_metrics.py Outdated Show resolved Hide resolved
cognite/extractorutils/uploader/assets.py Outdated Show resolved Hide resolved
cognite/extractorutils/uploader/assets.py Outdated Show resolved Hide resolved
@toondaey toondaey requested a review from ozangoktan July 14, 2023 12:14
ozangoktan
ozangoktan approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@ozangoktan ozangoktan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@toondaey toondaey merged commit cae2502 into master Jul 14, 2023
5 checks passed
@toondaey toondaey deleted the assets-uploader branch July 14, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozangoktan ozangoktan ozangoktan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toondaey @ozangoktan