Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api method to get the download URL instead of directly download #788

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

api method to get the download URL instead of directly download #788

wants to merge 6 commits into from

Conversation

Jacob-Eliat-Eliat
Copy link
Contributor

No description provided.

@Jacob-Eliat-Eliat Jacob-Eliat-Eliat marked this pull request as draft September 24, 2024 10:22
@codecov Codecov
Copy link

codecov bot commented Sep 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.62%. Comparing base (bbebb4a) to head (c2339e5).

Files with missing lines Patch % Lines
...ala/com/cognite/sdk/scala/v1/resources/files.scala 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #788      +/-   ##
==========================================
- Coverage   84.65%   84.62%   -0.03%     
==========================================
  Files          96       96              
  Lines        2678     2680       +2     
  Branches      229      232       +3     
==========================================
+ Hits         2267     2268       +1     
- Misses        411      412       +1
Files with missing lines Coverage Δ
...ala/com/cognite/sdk/scala/v1/resources/files.scala 93.15% <87.50%> (-1.22%) ⬇️

@Jacob-Eliat-Eliat Jacob-Eliat-Eliat marked this pull request as ready for review September 25, 2024 11:22
@github-actions github-actions bot added the Stale label Sep 27, 2024
@github-actions GitHub Actions
Copy link

This pull request seems a bit stale.. Shall we invite more to the party?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larshagencognite larshagencognite Awaiting requested review from larshagencognite larshagencognite is a code owner

@mr-celo mr-celo Awaiting requested review from mr-celo mr-celo is a code owner automatically assigned from cognitedata/r-alliance

@silvavelosa silvavelosa Awaiting requested review from silvavelosa

@dmivankov dmivankov Awaiting requested review from dmivankov

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jacob-Eliat-Eliat