Tests, Performance Improvements #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
cofinley
commented
Sep 14, 2023
cofinley
commented
- Add unit tests for algorithms
- Reduce scale generation time by 60+%
- Avoid recalculating chord suggestions for blocks if they have already been calculated
- Improve placement of suggested notes which were not played
- Find best octave based on note distance
- Fix same-pitch/octave-interval notes showing up as red (i.e. extra notes to not play) on piano roll
- Improve clarity of some terms, fns
- Don't recalculate chord suggestions in scales if you don't have to
- In the UI context, blocks already have chord suggestions generated and we
can just pass these in
- Fix chord pitch matching
- Playing the same pitch multiple times (i.e. octave intervals) won't result
in red notes on the piano preview
- Improve unmatched chord pitch placement
- Move it as close as possible to any unmatched played notes, but don't just
blindly use their octave as the chord pitch might be placed better at the
prev/next octave instead
- Start testing, still need to add github workflow yaml
- Clarify/disambiguate some terms
npm run watch should run a build but getting: FileNotFoundException: resources/public/js/compiled/app.js (No such file or directory)
Don't need/want to do browser tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.