Supports Symfony ^7.0 #476
Conversation
|
Looks like it's still a work in progress, I have an issue with Doctrine/Lexer. Doctrine/Lexer ^3.0 breaks the code and needs refactoring. |
tentacode
force-pushed
the
symfony7
branch
2 times, most recently
from
2e6e9ba
to
852abd8
Compare
|
hey @tentacode I'm glad that php matcher is useful for you 😊 I believe that long term solution should be to move away from doctrine/lexer and replace it with phplrt however as a quick fix, I'm fine with reducing support just to lexer ^3.0 - this might help you fix those broken tests. |
| @@ -21,15 +21,15 @@ | |||
| "ext-simplexml": "*", | |||
| "aeon-php/calendar": "^1.0", | |||
| "coduo/php-to-string": "^3", | |||
| "doctrine/lexer": "^1.0||^2.0" | |||
| "doctrine/lexer": "^1.0||^2.0||^3.0" | |||
There was a problem hiding this comment.
as already mentioned, I would simplify it by allowing only "^3.0"
There was a problem hiding this comment.
yeah, but as I'm on doctrine orm 3.0 I'm forced to use lexer 3 😅 I'll keep the fork because it's "workish" and I can use it in my project, but i'll remove merge request in your repository, good luck with the fix ! (if ever I have the time I'll look into it)
There was a problem hiding this comment.
hmm but if you remove 1 and 2, it should work for you and I could merge it, no?
There was a problem hiding this comment.
ah sorry I haven't read your message properly, lexer 3.0 has a lot of BC Break and the code of phpmatcher don't work with it :(
There was a problem hiding this comment.
yeah, I once tried to upgrade to 3.0 but it wasn't working and I didn't had then enough time to debug why but it seems that it wasn't a bug on my end but rather some changes in the internal behavior of lexer.
I'm gonna close this PR since it can't be merged anyway, sorry
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security
Description
Hello 👋 thanks for phpmatcher ! I'm using it extensively on all my projects ! I could not install it on a Symfony 7.0 project so here is the bump of composer. Feel free to tell me if there something else needed or if you prefer to do it yourself. Meanwhile I'll be using my fork.