Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add code scanning codeql and eslint workflows as well as fix formating #321

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

sk337
Copy link
Contributor

@sk337 sk337 commented Nov 14, 2023

No description provided.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@@ -86,7 +86,7 @@

if (module.exports.bannedIps.includes(ip))
module.exports.bannedIps = module.exports.bannedIps.filter((b) => b != ip);
res.send("unbanned "+ip);
res.send("unbanned "+ip.replaceAll("<", "&lt;").replaceAll(">", "$gt;"));

Check failure

Code scanning / CodeQL

Reflected cross-site scripting High

Cross-site scripting vulnerability due to a
user-provided value
.
@tpglitch
Copy link

Advanced security 🗿

@sk337
Copy link
Contributor Author

sk337 commented Nov 14, 2023

me: filters html tags in user input
github: XSS

@sk337
Copy link
Contributor Author

sk337 commented Nov 28, 2023

@codergautam review please

@codergautam
Copy link
Owner

will do soon, rn focusing on v2

@tpglitch
Copy link

holy balls i just caught a wild gautam reply
sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants