Fyst 462 implement some form d-400 ctc lines for both pdf and xml #4784
Conversation
|
Heroku app: https://gyr-review-app-4784-42cd867b2553.herokuapp.com/ |
app/lib/pdf_filler/nc_d400_pdf.rb
Outdated
| @@ -54,7 +54,8 @@ def hash_for_pdf | |||
| y_d400wf_li20a_pg2_good: @xml_document.at('IncTaxWith')&.text, | |||
| y_d400wf_li20b_pg2_good: @xml_document.at('IncTaxWithSpouse')&.text, | |||
| y_d400wf_li23_pg2_good: @xml_document.at('NCTaxPaid')&.text, | |||
| y_d400wf_li25_pg2_good: @xml_document.at('RemainingPayment')&.text | |||
| y_d400wf_li25_pg2_good: @xml_document.at('RemainingPayment')&.text, | |||
| y_d400wf_li10a_good: @xml_document.at('NumChildrenAllowed')&.text | |||
There was a problem hiding this comment.
why are all these suffixed with _good? These are the selectors on the pdf that was provided to us?
There was a problem hiding this comment.
yes it is provided to us and therefore i have no idea why _good 😅
| def qualifying_children_under_age_ssn_count=(value) | ||
| write_df_xml_value(__method__, value) | ||
| end | ||
|
|
There was a problem hiding this comment.
how do you decide when to create a writer for a given field?
| @@ -112,7 +112,7 @@ | |||
| end | |||
|
|
|||
| trait :head_of_household do | |||
| raw_direct_file_data { StateFile::XmlReturnSampleService.new.read('shiloh_mfs') } | |||
| raw_direct_file_data { StateFile::XmlReturnSampleService.new.read('shiloh_hoh') } | |||
There was a problem hiding this comment.
this was just typo in the past?
| intake.direct_file_data.qualifying_children_under_age_ssn_count = 2 | ||
|
|
||
| calculator_instance.calculate | ||
| expect(calculator_instance.lines[:NCD400_LINE_10B].value).to eq(deduction_amount) |
There was a problem hiding this comment.
[Dust] can we rename the deduction_amount to deduction_amt_for_two_children to be more explicit about the amount -- I was initially confused that there wasn't x 2 math going on but realized you had doubled the deduction amounts.
|
|
||
| def calculate_line_12a | ||
| # Add Lines 9, 10b, and 11 | ||
| # line 9 DeductionsFromFAGI is blank |
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
What was done?
How to test?