fix: version switch

[elrrrrrrr]

重构 useQueryState 统一使用受控模式

• 直接通过 window 对象乐观更新 query 值

Summary by CodeRabbit

• Refactor

  • Simplified the useQueryState hook for easier handling of URL query parameters.

• Bug Fixes

  • Updated state management in TagsList and VersionsList to improve consistency and reliability.

• Style

  • Removed redundant type annotations in the useQueryState function calls for cleaner code.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
cnpmweb	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 7, 2024 2:20pm

[coderabbitai]

Walkthrough

The recent updates focus on refining the useQueryState hook to streamline query parameter handling in URLs. This involves refactoring the hook's logic for setting and updating query parameters. Additionally, the changes propagate to components using this hook, ensuring consistent state management and simplifying default value handling across the application.

Changes

File Path	Change Summary
src/hooks/useQueryState.ts	Refactored useQueryState to simplify query parameter handling, updating logic for key and default value.
src/slugs/trends/index.tsx	Removed type annotation <string> in useQueryState call for vs state variable.
src/slugs/versions/index.tsx	Updated useQueryState usage in TagsList and VersionsList, replacing defaultValue with value in Segmented component.

Poem

In code we weave a tale so bright,
With useQueryState, our URLs light.
No more confusion, defaults in place,
Simplified logic, a cleaner space.
Trends and versions now align,
In our app, a smoother time.
To progress and clarity, we cheer,
As bunnies code with joy sincere! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

src/hooks/useQueryState.ts (1)

3-31: Refactor of useQueryState to use controlled mode and optimistically update query values looks good.

Consider adding detailed comments explaining the rationale behind not creating new history entries and the use of replaceState, as this could be non-intuitive for future maintainers.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 449c395 and 018e6e4.

Files selected for processing (3)

• src/hooks/useQueryState.ts (1 hunks)
• src/slugs/trends/index.tsx (1 hunks)
• src/slugs/versions/index.tsx (4 hunks)

Additional comments not posted (2)

src/slugs/trends/index.tsx (1)

15-15: Update to useQueryState usage aligns with the changes in the hook's implementation.

Verification successful

---

The useQueryState hook is correctly imported and used in the src/slugs/trends/index.tsx file. The removal of the type annotation <string> aligns with the changes in the hook's implementation.

• src/slugs/trends/index.tsx
  • Line 15: const [vs, setVS] = useQueryState('vs', '');

Scripts executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify the behavior of the Trends component with the updated `useQueryState` hook.

# Test: Check if the component correctly updates and reads the URL query parameters.
rg --type typescript $'useQueryState' src/slugs/trends/index.tsx

Length of output: 98

---

---

Script:

#!/bin/bash
# Description: Verify the behavior of the Trends component with the updated `useQueryState` hook.

# Test: Check if the component correctly updates and reads the URL query parameters.
rg --type ts $'useQueryState' src/slugs/trends/index.tsx

Length of output: 153

src/slugs/versions/index.tsx (1)

51-51: Changes in useQueryState usage in TagsList and VersionsList components are consistent with the hook's new implementation.

Also applies to: 74-74, 111-111, 134-134