fix(volo-http): append query for StripPrefixLayer
#489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous implementation, the nested router would only get the inner uri but not its query, the query would be dropped and the inner router would never be able to get it. This commit fixes it by appending the query if it exists. Fixes: cloudwego#488 Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
PureWhiteWu
approved these changes
Aug 26, 2024
Millione
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the previous implementation, the nested router would only get the inner uri but not its query, the query would be dropped and the inner router would never be able to get it.
Solution
This commit fixes it by appending the query if it exists.
Fixes: #488