[tsh] Initial support for teleport tsh, GEODESIC_PORT #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goruha
reviewed
Apr 17, 2019
| @@ -150,7 +150,7 @@ function use() { | |||
| --publish ${GEODESIC_PORT}:${GEODESIC_PORT} | |||
| --name "${DOCKER_NAME}" | |||
| --rm | |||
| --env KUBERNETES_API_PORT=${GEODESIC_PORT}) | |||
| --env GEODESIC_PORT=${GEODESIC_PORT}) | |||
There was a problem hiding this comment.
I support this. I want to generalize it so we can use it for both kubectl and teleport. The port can be overloaded,
There was a problem hiding this comment.
Also, I like the consistency where the LHS==RHS env name
osterman
approved these changes
Apr 17, 2019
Nuru
changed the title
leb4r
pushed a commit
that referenced
this pull request
Jan 25, 2022
Co-authored-by: osterman <osterman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
KUBERNETES_API_PORTtoGEODESIC_PORTwhy