Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add restriction on tab opening to the current active tab #13

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Add restriction on tab opening to the current active tab #13

merged 2 commits into from
Jan 11, 2024

Commits on Jan 11, 2024

  1. Add restriction on tab opening to the current active tab 

    In the existing extension, any tab initiating a PrivateToken request for
a trusted issuer is going to trigger the associated attester tab
opening. This might interrupt the user flow.
This commit introduces an improvement to only allow the current active
tab to open a new tab upon a PrivateToken request.
    @thibmeu
    thibmeu committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    e94d5cc View commit details
    Browse the repository at this point in the history

  2. Fix headerToToken value check from null to undefined 

    `headerToToken` returns `Promise<string | undefined>`. However, the existing
check assessed `headerToToken().then(value => value === null ? something
: somethingElse)`.
This should never be true.
Instead, this check is replaced with `!value`.
    @thibmeu
    thibmeu committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    c8be6ce View commit details
    Browse the repository at this point in the history