-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CRUD endpoints for infrastructure access endpoints #3184
base: master
Are you sure you want to change the base?
Add CRUD endpoints for infrastructure access endpoints #3184
Conversation
} | ||
|
||
type UpdateInfrastructureTargetParams struct { | ||
ID string `json:"hostname"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need json
field here
params.Page = 1 | ||
} | ||
|
||
var applications []Target |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: targets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally you want a collection of singular names. i.e. things := []Thing
} | ||
|
||
type UpdateInfrastructureTargetParams struct { | ||
ID string `json:"hostname"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ID string `json:"hostname"` | |
ID string `json:"-"` |
Description
We are recently added new endpoints for infrastructure access. We are looking to get these endpoints reflected in the terraform provider documentation. This PR contains the client side changes necessary for that. It writes CRUDL functions for the terraform provider to interact with our new endpoints.
These endpoints are working in prod, we are planning to have the OpenAPI schema published to
developers.cloudflare.com/api
by end of day today.Has your change been tested?
I've tested these changes through acceptance tests.
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.