Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kube burner Report - OCP Wrapper Dashboard using latest grafonnet library. #80

Merged
merged 6 commits into from
Oct 24, 2023
Merged

Kube burner Report - OCP Wrapper Dashboard using latest grafonnet library. #80

merged 6 commits into from
Oct 24, 2023

Conversation

vishnuchalla
Copy link
Collaborator

@vishnuchalla vishnuchalla commented Sep 29, 2023 •
edited
Loading

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Kube burner Report - OCP Wrapper Dashboard using latest grafonnet library.

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

Tested using v2 instructions in Makefile.

Added: Support for multiple multiple folders, python client
f504c80 
Modified: Internal logic for creating/updating dashboards
Deleted: Removed old logic as it is not flexible for automation
@vishnuchalla vishnuchalla mentioned this pull request Sep 29, 2023
Closed
@vishnuchalla vishnuchalla marked this pull request as ready for review September 29, 2023 19:23
rsevilla87
rsevilla87 reviewed Oct 5, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
jtaleric
jtaleric reviewed Oct 5, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@rsevilla87 rsevilla87 mentioned this pull request Oct 11, 2023
Merged
7 tasks
@vishnuchalla vishnuchalla force-pushed the kube-burner branch 2 times, most recently from a7b6203 to 3604bde Compare October 12, 2023 15:50
jtaleric
jtaleric reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of nits

Makefile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@vishnuchalla vishnuchalla force-pushed the kube-burner branch 2 times, most recently from 29bd6e0 to 82877eb Compare October 13, 2023 02:06
@vishnuchalla
Copy link
Collaborator Author

@jtaleric @rsevilla87 just a gentle reminder.

afcollins
afcollins reviewed Oct 13, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@jtaleric
Copy link
Member

Couple of follow on questions -- I ran the make locally and all looks good there...

   "description": "Performance dashboard for Red Hat OpenShift",
   "editable": "true",

Should we add a tag or commit id to the description -- this way if we do change dashboards it is clear to the engineer if they are running with the latest dashboards or not?

Also, should we s/true/false? For the non-live cluster dashboards?

@vishnuchalla
Copy link
Collaborator Author

vishnuchalla commented Oct 19, 2023 •
edited
Loading

Couple of follow on questions -- I ran the make locally and all looks good there...

   "description": "Performance dashboard for Red Hat OpenShift",
   "editable": "true",

Should we add a tag or commit id to the description -- this way if we do change dashboards it is clear to the engineer if they are running with the latest dashboards or not?

Also, should we s/true/false? For the non-live cluster dashboards?

Yes I think for these dashboards, we can disable the direct edits and take them through PRs as we plan to standardize the process. So everyone should be using a viewer user with view perms to access the dashboards but not admin. Because grafana does provide admin user with full privileges (i.e even if we set editable=false there will still be options to override it).

Also Added commit hash as a tag to the dashboard to make sure that we are looking at the latest ones.
Screenshot from 2023-10-19 19-39-50

@vishnuchalla
Copy link
Collaborator Author

vishnuchalla commented Oct 23, 2023 •
edited
Loading

@jtaleric @rsevilla87 Happy Monday! Just a gentle reminder on this PR.

@rsevilla87 rsevilla87 self-requested a review October 24, 2023 15:36
rsevilla87
rsevilla87 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@rsevilla87 rsevilla87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rsevilla87 rsevilla87 merged commit 6aa348b into cloud-bulldozer:master Oct 24, 2023
2 checks passed
@vishnuchalla vishnuchalla deleted the kube-burner branch October 31, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsevilla87 rsevilla87 rsevilla87 approved these changes

@smalleni smalleni Awaiting requested review from smalleni

@dry923 dry923 Awaiting requested review from dry923

@jtaleric jtaleric Awaiting requested review from jtaleric

@afcollins afcollins Awaiting requested review from afcollins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vishnuchalla @jtaleric @afcollins @rsevilla87