Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go-commons remove ipsec func #145

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Update go-commons remove ipsec func #145

merged 1 commit into from
Jun 5, 2024

Conversation

jtaleric
Copy link
Member

@jtaleric jtaleric commented Jun 5, 2024 •
edited
Loading

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Moving to latest go-commons and using those functions to determine ipsec

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Update go-commons remove ipsec func
189775f 
Moving to latest go-commons and using those functions to determine ipsec

Signed-off-by: Joe Talerico <rook@redhat.com>
@jtaleric jtaleric requested a review from krishvoor June 5, 2024 18:05
krishvoor
krishvoor approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@krishvoor krishvoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

vishnuchalla
vishnuchalla approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@vishnuchalla vishnuchalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jtaleric jtaleric merged commit ede99db into cloud-bulldozer:main Jun 5, 2024
5 checks passed
@jtaleric jtaleric deleted the fix-metadata branch June 5, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishvoor krishvoor krishvoor approved these changes

@vishnuchalla vishnuchalla vishnuchalla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] ipsec not correctly reporting in metadata
3 participants
@jtaleric @krishvoor @vishnuchalla