Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource azurerm_cdn_frontdoor_secret #5

Merged
merged 5 commits into from
Jun 14, 2024

Conversation

blongv
Copy link
Contributor

@blongv blongv commented Jun 11, 2024

Fixes #4 .

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Changes proposed in this pull request

  • Create resource azurerm_cdn_frontdoor_secret if custom_domains.key_vault_certificate_id is defined.
  • Use the secret as azurerm_cdn_frontdoor_custom_domain.cdn_frontdoor_secret_id.

@claranet/fr-azure-reviewers

Copy link
Member

@Shr3ps Shr3ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update or add an example with this new feature?
Also, you need to update the README file with terraform-docs (CI is failing)

@blongv
Copy link
Contributor Author

blongv commented Jun 12, 2024

Can you please update or add an example with this new feature? Also, you need to update the README file with terraform-docs (CI is failing)

The issue #4 has an example. I just submitted the README fix after installing your pre-commit hooks. Thanks for reviewing.

@Shr3ps
Copy link
Member

Shr3ps commented Jun 12, 2024

Can you please update or add an example with this new feature? Also, you need to update the README file with terraform-docs (CI is failing)

The issue #4 has an example. I just submitted the README fix after installing your pre-commit hooks. Thanks for reviewing.

Thanks for the README update!
About the example, I mean it would be nice if you can update the examples/main/modules.tf file (and run pre-commit again for the README update) with the elements you put in the issue.
It will be helpful for users/people who use our module.

@blongv
Copy link
Contributor Author

blongv commented Jun 12, 2024

About the example, I mean it would be nice if you can update the examples/main/modules.tf file (and run pre-commit again for the README update) with the elements you put in the issue. It will be helpful for users/people who use our module.

I apologize because I am not very familiar with pre-commit errors mentioning files outside this git project like the following:

$ git commit -am 'chore: update example for custom domains'
trim trailing whitespace................................................................Passed
fix end of files........................................................................Passed
check json..........................................................(no files to check)Skipped
check yaml..........................................................(no files to check)Skipped
check for broken symlinks...........................................(no files to check)Skipped
check for added large files.............................................................Passed
detect private key......................................................................Passed
Terraform fmt...........................................................................Passed
Terraform docs......................................................(no files to check)Skipped
Terraform validate..................................................(no files to check)Skipped
Terraform validate with tflint......................................(no files to check)Skipped
Terraform validate with tfsec (deprecated, use "terraform_trivy").......................Passed
error: invalid object 100644 496b1048c932a54707cbd671fb29e27c16197509 for 'examples/automation-account/README.md'
error: Error building trees

I believe examples/automation-account is from the azurecaf project but I'm not sure why me updating examples/main/modules.tf would cause the above error. What do you suggest I do?

@Shr3ps
Copy link
Member

Shr3ps commented Jun 12, 2024

About the example, I mean it would be nice if you can update the examples/main/modules.tf file (and run pre-commit again for the README update) with the elements you put in the issue. It will be helpful for users/people who use our module.

I apologize because I am not very familiar with pre-commit errors mentioning files outside this git project like the following:

$ git commit -am 'chore: update example for custom domains'
trim trailing whitespace................................................................Passed
fix end of files........................................................................Passed
check json..........................................................(no files to check)Skipped
check yaml..........................................................(no files to check)Skipped
check for broken symlinks...........................................(no files to check)Skipped
check for added large files.............................................................Passed
detect private key......................................................................Passed
Terraform fmt...........................................................................Passed
Terraform docs......................................................(no files to check)Skipped
Terraform validate..................................................(no files to check)Skipped
Terraform validate with tflint......................................(no files to check)Skipped
Terraform validate with tfsec (deprecated, use "terraform_trivy").......................Passed
error: invalid object 100644 496b1048c932a54707cbd671fb29e27c16197509 for 'examples/automation-account/README.md'
error: Error building trees

I believe examples/automation-account is from the azurecaf project but I'm not sure why me updating examples/main/modules.tf would cause the above error. What do you suggest I do?

Hum very weird error, never got that. Maybe bypass pre-commit with the --no-verify param for this one?

@Shr3ps Shr3ps merged commit db0ccc7 into claranet:master Jun 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Create azurerm_cdn_frontdoor_secret based on existing keyvault certificate
3 participants