Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated version of diagnostic-settings from 6.2.0 to 6.5.0 #3

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

noblejasper
Copy link

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Changes proposed in this pull request

  • Diagnostic-settings version 6.2.0 was specified as old, updated to 6.5.0.
    • If they remain out of date, the following errors and warnings occur
│ Warning: Argument is deprecated
│ 
│   with module.cdn_frontdoor_standard.module.diagnostics.azurerm_monitor_diagnostic_setting.main[0],
│   on .terraform/modules/cdn_frontdoor.diagnostics/r-diagnostic.tf line 7, in resource "azurerm_monitor_diagnostic_setting" "main":
│    7: resource "azurerm_monitor_diagnostic_setting" "main" {
│ 
│ `retention_policy` has been deprecated in favor of `azurerm_storage_management_policy` resource - to learn more
│ https://aka.ms/diagnostic_settings_log_retention
│ Error: creating Monitor Diagnostics Setting "default" for Resource "/subscriptions/xxx/resourceGroups/xxx/providers/Microsoft.Cdn/profiles/xxxx": diagnosticsettings.DiagnosticSettingsClient#CreateOrUpdate: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="BadRequest" Message="Diagnostic settings does not support retention for new diagnostic settings."

@claranet/fr-azure-reviewers

BzSpi added a commit to noblejasper/terraform-azurerm-cdn-frontdoor that referenced this pull request Apr 5, 2024
BzSpi added a commit to noblejasper/terraform-azurerm-cdn-frontdoor that referenced this pull request Apr 5, 2024
@BzSpi BzSpi force-pushed the fix/verup-diagnostic-settings branch from d1ff514 to b108867 Compare April 5, 2024 07:06
@BzSpi
Copy link
Contributor

BzSpi commented Apr 5, 2024

Thank you for your contribution, I've added some modifications.

@BzSpi BzSpi force-pushed the fix/verup-diagnostic-settings branch from b108867 to 8259d48 Compare April 5, 2024 09:13
@BzSpi BzSpi merged commit c65937d into claranet:master Apr 5, 2024
3 checks passed
BzSpi added a commit that referenced this pull request Apr 5, 2024
Changed
* [GH-3](#3): Bump diagnostic settings version to 6.5.0
@noblejasper noblejasper deleted the fix/verup-diagnostic-settings branch April 6, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants