Converted ckeditor5-dev-* packages to ESM #1011
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unneeded `type` property from config.
Internal: Removed the jsdoc-plugins package.
pomek
commented
Sep 19, 2024
.eslintrc.js
Outdated
Comment on lines
18
to
19
| // ESLint does not understand `import ... with { ... }`. | ||
| // See: https://github.com/eslint/eslint/discussions/15305. |
pomek
commented
Sep 19, 2024
.eslintrc.js
Outdated
| ], | ||
| rules: { | ||
| 'no-console': 'off', | ||
| 'ckeditor5-rules/require-file-extensions-in-imports': 'off', | ||
| 'mocha/no-global-tests': 'off', // TODO: remove when all mocha tests are removed. |
pomek
commented
Sep 19, 2024
.eslintrc.js
Outdated
| @@ -29,9 +35,27 @@ module.exports = { | |||
| }, | |||
| overrides: [ | |||
| { | |||
| files: [ './packages/ckeditor5-dev-build-tools/tests/**/*' ], | |||
| files: [ | |||
| // TODO: add packages as they are migrated to ESM. | |||
Internal (tests): Converted the `ckeditor5-dev-tests` package to ESM. Internal: The `ckeditor5-dev` repository is now marked as a module. Internal: Redesigned the CI flow. Now, each package test runner is defined in a dedicated step instead of as a whole. MAJOR BREAKING CHANGE (tests): The IntelliJ Karma configuration path needs to be updated. Now it ends with the `cjs` suffix instead of `js`.
This was referenced Sep 19, 2024
Aligned to `ckeditor5-dev` ESM changes
Internal: Temporary changes to enable alpha release from the `epic/3757-esm` branch.
pomek
commented
Sep 20, 2024
| CKE5_GITHUB_REPOSITORY="ckeditor5-dev" | ||
| CKE5_CIRCLE_APPROVAL_JOB_NAME="release_approval" | ||
| # CKE5_GITHUB_RELEASE_BRANCH="master" | ||
| CKE5_GITHUB_RELEASE_BRANCH="epic/3757-esm" |
There was a problem hiding this comment.
This change must be updated to #master before merging. The entire commit 1cc2de5 should be reverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: The CKEditor 5 Dev packages are now ESM.
Other: The
@ckeditor/jsdoc-pluginspackage is no longer available as CKEditor 5 documentation uses TypeScript sources to prepare API docs. The package is no longer use by us anywhere. Hence, we decided to remove a dead code.MAJOR BREAKING CHANGE (utils): The
builds.getDllPluginWebpackConfig()function is now asynchronous now.MAJOR BREAKING CHANGE (utils): The following functions from the
bundlerobject are no longer available:createEntryFile(),getEditorConfig(),getPlugins().MAJOR BREAKING CHANGE (utils): The following functions from the
streamobject are no longer available:isTestFile(),isSourceFile(),isJSFile().MAJOR BREAKING CHANGE (utils): The
styles.themeLogger()function is no longer exposed publicly.MAJOR BREAKING CHANGE (tests): The IntelliJ Karma configuration path needs to be updated. Now, it ends with the
cjssuffix instead ofjs.MAJOR BREAKING CHANGE (docs): The package uses only TypeDoc to build the documentation. The
build()function no longer supportstypeproperty in the configuration.MAJOR BREAKING CHANGE: The following packages have been converted to ESM. To load them, use an
importstatement instead ofrequire().@ckeditor/ckeditor5-dev-build-tools@ckeditor/ckeditor5-dev-bump-year@ckeditor/ckeditor5-dev-ci@ckeditor/ckeditor5-dev-dependency-checker@ckeditor/ckeditor5-dev-docs@ckeditor/ckeditor5-dev-release-tools@ckeditor/ckeditor5-dev-stale-bot@ckeditor/ckeditor5-dev-tests@ckeditor/ckeditor5-dev-transifex@ckeditor/ckeditor5-dev-translations@ckeditor/ckeditor5-dev-utils@ckeditor/ckeditor5-dev-web-crawlerAdditional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.