add support for unicode header names #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidread
suggested changes
Aug 17, 2020
Merged
|
First, thanks for the PR and the review. Anything needed except a rebase of the branch with HEAD? |
|
This looks good to me, but @OriHoch can you resolve the merge conflict? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, unicode characters in headers are encoded to ascii using unidecode library.
This PR adds a config option (
ckanext.xloader.unicode_headers) which allows to keep unicode charactes in the column namesIncludes new tests for this functionality + verified no regressions in existing tests