Add MLSMessage framework #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add MLSMessage Add tests of MLSMessage framework functionality Begin adding support for MLSMessage-formatted proposals Add MLSMessage-based Commit Migrate State tests to new MLSMessage methods Move Session over to MLSMessage framework Convert application data protect/unprotect to MLSMessage Move external join to MLSMessage framework Remove MLSPlaintext/MLSCiphertext from state.h/.cpp Remove MLSPlaintext/MLSCiphertext from the remainder of src/* Remove old MLSPlaintext and MLSCiphertext Remove namespace mls2 Update test vectors to use MLSMessage Dead code removal Remove rvalue reference silliness clang-format
bifurcation
commented
Apr 28, 2022
bifurcation
commented
Apr 29, 2022
suhasHere
approved these changes
Apr 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponds to mlswg/mls-protocol#523
This required a bit of conceptual realignment in the API, since it had been oriented around the idea that you could convert between MLSPlaintext and MLSCiphertext. Now you have to declare your intent earlier, thus the
MessageOptsstructure.As a side benefit, because this is a clean-slate reimplementation of MLSCiphertext, we now have the ability to add message padding.