Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

refactor the README #23

Merged
merged 2 commits into from
Oct 9, 2023
Merged

refactor the README #23

merged 2 commits into from
Oct 9, 2023

Conversation

bonifaido
Copy link
Member

@bonifaido bonifaido commented Oct 5, 2023 •
edited
Loading

Description

Refactor the README to represent the current NASP direction/architecture/vision.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@bonifaido bonifaido self-assigned this Oct 5, 2023
@bonifaido bonifaido marked this pull request as ready for review October 9, 2023 07:47
@bonifaido bonifaido requested a review from a team October 9, 2023 07:47
baluchicken
baluchicken reviewed Oct 9, 2023
View reviewed changes
Copy link
Contributor

@baluchicken baluchicken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
baluchicken
baluchicken reviewed Oct 9, 2023
View reviewed changes
Copy link
Contributor

@baluchicken baluchicken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks more readable to me, but just nits and the original one was fine as well.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@bonifaido @baluchicken
Apply suggestions from code review
d4a7955 
Co-authored-by: Balint Molnar <balintmolnar91@gmail.com>
@bonifaido bonifaido merged commit 0e8e02c into main Oct 9, 2023
1 check passed
@bonifaido bonifaido deleted the readme-refactor branch October 9, 2023 13:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@baluchicken baluchicken baluchicken approved these changes

Assignees

@bonifaido bonifaido

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bonifaido @baluchicken