Adjusted package_method to allow package names with whitespace in the middle #5523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function cache only used the args values, which in some cases could lead to mixing results from different functions with the same arguments. Ticket: CFE-4244 Changelog: Cashed policy function results now take into account number of arguments and function name. Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech> Co-authored-by: Alexis Mousset <alexis.mousset@rudder.io>
Two reasons for this: 1. CONTRIBUTING.md says to do this at the top 2. the `ctx` argument was actually used before the assert Ticket: None Changelog: None Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
CFE-4244: Add the function name to the result cache key
Ticket: ENT-10470 Issue was that these failures were visible in Jenkins, turning build "unstable".
With fixed headers not including <config.h>.
With libntech's headers no longer pulling in platform.h, we need to add it together with some other headers to some places in the codebase.
…_cleanup_fixes Add missing #include's previously pulled in by libntech
Change suppress fail to soft fail on known failing tests
in bodies having local parameters. This also prevents a memory corruption when an attribute contains external vars but no local vars. Ticket: CFE-4254 Changelog: Bodies can now inherit attributes containing global variables Signed-off-by: Alexis Mousset <alexis.mousset@rudder.io>
CFE-4254: Allow inheriting attributes using global variables in bodies having local parameters
We require OpenSSL 1.0.0 or newer so we don't need this compatibility code for older versions.
With libcrypto-compat code removed.
…crypto_compat Do not #include libcrypto-compat
cfengine/nova@8b8726e changed cf-hub behavior for ENT-9825 This change fixes an issue with hubs that have SELinux set to enforce. Hubs which do not have SELinux set to enforce are unaffected by this issue. Ticket: ENT-10696 Changelog: title
ENT-10696: Added selinux policy to allow cf-hub to initiate scheduled reports
…d in kerenl.core_pattern It's possible for coredumpctl to be present yet the system not correctly configured to use systemd-coredump which results in coredumpctl not being able to find core files. This change restricts the use of coredumpctl for when systemd-coredump is present in sysctl kernel.core_pattern. Ticket: ENT-9985 Changelog: Title
ENT-9985: Made cf-support use coredumpctl for core analysis only when configured in kerenl.core_pattern
Created SECURITY.md
Bumps [libntech](https://github.com/cfengine/libntech) from `49cd554` to `8545ebb`. - [Commits](NorthernTechHQ/libntech@49cd554...8545ebb) --- updated-dependencies: - dependency-name: libntech dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Lluis Campos <lluis.campos@northern.tech>
Signed-off-by: Lluis Campos <lluis.campos@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Updated links to libntech after move
- cf-agent.exe is not always installed "in-time" ENT-10699 - job uses latest nightly instead of building the PR code ENT-10754 Ticket: none Changelog: none
LANG is not sufficient to guard against odd environment vars, LC_ALL is a master override so prefer that. Ticket: ENT-10753 Changelog: title
rhel needs fakeroot for make check debian seems to include fakeroot in existing deps in INSTALL file both need libxml2 development package to pass make check Ticket: none Changelog: none
Their first run they change an original/source file and so on subsequent runs the tests failed due to the original being incorrect. Ticket: ENT-10761 Changelog: none
…tance Disable win-acceptance tests for now due to two issues
ENT-10761: Fixed two acceptance tests which could only run once before failing
To prevent multiple processes from opening/closing the DB at the
same time. From what we have seen, the *Invalid argument* issues
only happen when multiple processes try to work with the DB,
multiple threads inside a single process don't seem to hit the
trigger.
Also, we have seen that the issues happen when LMDB tries to use
a robust (shared inter-process) mutex that was already destroyed.
Ticket: ENT-11543
Changelog: CFEngine processes no longer suffer from the "Invalid
argument" issues when working with LMDB
…file Try to acquire file lock when closing DB
…ginning of every minute This could fix issues if things are slow and agent runs end up getting skipped if cf-execd wakes up too late. Changelog: Title Ticket: ENT-11765 Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Ticket: ENT-10699 Changelog: none
Ticket: ENT-10699 Changelog: none
ENT-10699: Fixed windows acceptance test workflow
ENT-11765: Changed cf-execd's sleep behavior so it attempts to wake up at the beginning of every minute
We need to take care of the newly required checks in configure.ac
because we are responsible for producing config.h usable for both
us and libntech.
Ticket: CFE-4380
Changelog: File copying now uses more efficient implementation on
Linux platforms
Copying should respect holes in sparse files, but if the original file is not sparse, it's not a goal of the copy code to create a sparse copy. So to test respecting holes in sparse files during copying, we need to create the source files as sparse files. Ticket: CFE-4380 Changelog: None
20.04 has an older version of valgrind that doesn't support the `FICLONE` `ioctl()`. Ticket: CFE-4380 Changelog: None
…ent_data_copying Support libntech's new efficient file/data copying
There was an issue with 3.18.x version of this job which required this change. Ticket: ENT-11771 Changelog: none
ENT-11771: Adjust windows acceptance test job workflow to use only C: partition
To make the windows acceptance workflow go faster I tested only one failing test. This change wasn't noticed when committing the fix for using only C: partition. Ticket: ENT-11771 Changelog: none
Fixed mistakenly committed test change
…libntech-1450dcb Bump libntech from `5f195b2` to `1450dcb`
… middle On Windows with winget package names often have spaces. The previous implementation used sscanf to grab the first space-delimited token as the name. This change uses libntech string_lib TrimWhitespace() to only remove leading and trailing whitespace. Ticket: CFE-4397 Changelog: title
|
will see how bad this goes, the code is completely untested |
|
retry after fixing code :) |
|
more places name needs to be properly trimmed, retry |
craigcomstock
force-pushed
the
CFE-4397/master
branch
from
560aa64
to
34bcff1
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows with winget package names often have spaces.
The previous implementation used sscanf to grab the first space-delimited token as the name.
This change uses libntech string_lib TrimWhitespace() to only remove leading and trailing whitespace.
Ticket: CFE-4397
Changelog: title