Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-form-select] fixed console error #4101

Merged
merged 2 commits into from
May 13, 2024
Merged

[terra-form-select] fixed console error #4101

merged 2 commits into from
May 13, 2024

Conversation

sdadn
Copy link
Contributor

@sdadn sdadn commented May 13, 2024

Summary

This PR fixes a console error caused by an invalid custom prop being added to the DOM. This was fixed by destructuring the prop out of customProps.

This PR also releases this change.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

This was tested by running a terra-form-select example locally and ensuring that there is no console error after the change.

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details


Thank you for contributing to Terra.
@cerner/terra

@sdadn sdadn self-assigned this May 13, 2024
@sdadn sdadn requested a review from a team as a code owner May 13, 2024 14:19
@github-actions github-actions bot temporarily deployed to preview-pr-4101 May 13, 2024 14:20 Destroyed
@sdadn sdadn merged commit 3f404c3 into main May 13, 2024
22 checks passed
@sdadn sdadn deleted the form-select-console-fix branch May 13, 2024 15:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants