fix: avoid race condition when creating policies #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you're trying to startup multiple Yates clients simultaneously, it's possible that you hit an error where on client tries to create a policy that the other client has already created. This occurs because we read *all* abilities in one go. To avoid this, we check the ability table once per RLS policy, and we do it inside a transaction with a lock. This means that the second client will behave correctly and not try to create the policy again.
LucianBuzzo
force-pushed
the
lucianbuzzo/create-policy-race-condition
branch
from
b7b3b78
to
4d77dfb
Compare
|
Published beta package version: |
|
Sr-santi
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you're trying to startup multiple Yates clients simultaneously, it's possible that you hit an error where on client tries to create a policy that the other client has already created.
This occurs because we read all abilities in one go. To avoid this, we check the ability table once per RLS policy, and we do it inside a transaction with a lock. This means that the second client will behave correctly and not try to create the policy again.